Skip to content

Remove some unnecessary .into() calls #135269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove some unnecessary .into() calls #135269

merged 1 commit into from
Jan 9, 2025

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Jan 8, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2025

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

compiler-errors
compiler-errors approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to separate your contributions between compiler/library in the future, esp if you're running clippy lints (which I assume this is just the fixes from useless_conversions), but this seems fine.

@compiler-errors
Copy link
Member

compiler-errors commented Jan 8, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 8, 2025

📌 Commit eb917ea has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2025
Merged
@jhpratt jhpratt mentioned this pull request Jan 9, 2025
Closed
@bors bors merged commit a1cadea into rust-lang:master Jan 9, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@fmease fmease

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

5 participants

@estebank @rustbot @compiler-errors @bors @fmease